linux-kernel - Re: PATCH] block: update add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <487B3160.8070404@kernel.org>
Date:	Mon, 14 Jul 2008 19:58:40 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Rufus & Azrael <rufus-azrael@...ericable.fr>
CC:	Linux-kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: PATCH] block: update add_partition() error handling

Rufus & Azrael wrote:
> Hello TJ,
> 
> 
> I try your patch but it fails on apply (see check.c.X in attachment) and
> when compiling the kernel this build error occurs :l
> 
> fs/partitions/check.c:347: erreur: conflicting types for ‘add_partition’
> include/linux/genhd.h:533: erreur: previous declaration of
> ‘add_partition’ was here
> fs/partitions/check.c: In function ‘add_partition’:
> fs/partitions/check.c:406: attention : ‘return’ with a value, in
> function returning void
> fs/partitions/check.c:412: attention : ‘return’ with a value, in
> function returning void
> fs/partitions/check.c: In function ‘rescan_partitions’:
> fs/partitions/check.c:512: erreur: valeur void n'a pas été ignorée comme
> elle aurait dû l'être
> make[2]: *** [fs/partitions/check.o] Erreur 1
> make[1]: *** [fs/partitions] Erreur 2
> make: *** [fs] Erreur 2

Hmmm... are you sure?

> git checkout -f masterAlready on branch "master"
> cat .git/refs/heads/master
bce7f793daec3e65ec5c5705d2457b81fe7b5725
> patch -p1 < ../work/patches/update-add_partition-error
patching file block/ioctl.c
patching file fs/partitions/check.c
Hunk #1 succeeded at 344 (offset 2 lines).
Hunk #2 succeeded at 383 (offset 2 lines).
Hunk #3 succeeded at 505 (offset 2 lines).
patching file include/linux/genhd.h
> make block/genhd.o
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CALL    scripts/checksyscalls.sh
  CC      block/genhd.o
block/genhd.c: In function ‘add_disk’:
block/genhd.c:195: warning: ignoring return value of
‘sysfs_create_link’, declared with attribute warn_unused_result

The offset message is due to skipping earlier patches but it should just
work.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/