linux-kernel - [PATCH] JMicron JM20337 USB-SATA data corruption bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080720051326.GA5478@notebook.homenet.local>
Date:	Sun, 20 Jul 2008 07:13:27 +0200
From:	Tomas Styblo <tripie@...n.org>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] JMicron JM20337 USB-SATA data corruption bugfix - device
	152d:2338

Hello,

this message includes a patch that provides a workaround for
a silent data corruption bug caused by incorrect error handling in
the JMicron JM20337 Hi-Speed USB to SATA & PATA Combo Bridge chipset,
USB device id 152d:2338.

- the problem occurs quite rarely, approx. once for 
  every 20 GB of transfered data during heavy load

- it seems that only read operations are affected

- the problem is accompanied by these messages in syslog each
  time it occurs:

May 17 15:06:56 kernel: sd 6:0:0:0: [sdb] Sense Key : 0x0 [current] 
May 17 15:06:56 kernel: sd 6:0:0:0: [sdb] ASC=0x0 ASCQ=0x0

- the bug is not detected as an error and incorrect data is returned, 
  causing insidious data corruption

- tested with 3 external disk enclosures (Akasa Integral AK-ENP2SATA-BL) 
  with different disks on different computers, with kernel 2.6.24 and 2.6.25

- the patch provides a crude workaround by detecting the error condition
  and retrying the faulty transfer

The fix needs a review as I don't know much about USB and SCSI.  
It's possible that this approach is wrong and that the problem should
be fixed somewhere else.

There are other problems with this chipset that make it necessary 
to disconnect and power off the enclosure from time to time, but at least
there's no data corruption anymore.

-- 
Tomas Styblo <tripie@...n.org>
PGP: C97EA4B6 / 817E B8A8 1AFD 3256 3181  A730 85CF 7BEB C97E A4B6

View attachment "linux-kernel-2.6.25.9-usb-storage-jmicron-JM20337-no-sense-bugfix.patch" of type "text/plain" (1216 bytes)

Content of type "application/pgp-signature" skipped