linux-kernel - Re: [RFC] parser: add const to parser token table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080720073735.GA12331@rain>
Date:	Sun, 20 Jul 2008 11:37:35 +0400
From:	Evgeniy Dushistov <dushistov@...l.ru>
To:	Steven Whitehouse <swhiteho@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Alexander Viro <aviro@...hat.com>
Subject: Re: [RFC] parser: add const to parser token table

On Thu, Jul 17, 2008 at 02:22:52PM +0100, Steven Whitehouse wrote:
> Hi,
> 
> Any objections to the following patch? If not I'll send it on to Linus.
> 
> This patch adds a "const" to the parser token table. I've done an
> allmodconfig build to see if this produces any warnings/failures and the
> patch includes a fix for the only warning that was produced.
> 
> Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
> Cc: Alexander Viro <aviro@...hat.com>
> Cc: Evgeniy Dushistov <dushistov@...l.ru>
> 
> 
> diff --git a/fs/ufs/super.c b/fs/ufs/super.c
> index 85b22b5..506f724 100644
> --- a/fs/ufs/super.c
> +++ b/fs/ufs/super.c
> @@ -1232,7 +1232,7 @@ static int ufs_show_options(struct seq_file *seq, struct vfsmount *vfs)
>  {
>  	struct ufs_sb_info *sbi = UFS_SB(vfs->mnt_sb);
>  	unsigned mval = sbi->s_mount_opt & UFS_MOUNT_UFSTYPE;
> -	struct match_token *tp = tokens;
> +	const struct match_token *tp = tokens;
>  
>  	while (tp->token != Opt_onerror_panic && tp->token != mval)
>  		++tp;
> diff --git a/include/linux/parser.h b/include/linux/parser.h
> index 7dcd050..cc554ca 100644
> --- a/include/linux/parser.h
> +++ b/include/linux/parser.h
> @@ -14,7 +14,7 @@ struct match_token {
>  	const char *pattern;
>  };
>  
> -typedef struct match_token match_table_t[];
> +typedef const struct match_token match_table_t[];
>  
>  /* Maximum number of arguments that match_token will find in a pattern */
>  enum {MAX_OPT_ARGS = 3};
> 
Acked-by: Evgeniy Dushistov <dushistov@...l.ru>

-- 
/Evgeniy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/