linux-kernel - Re: [PATCH 02/23] tracehook: exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721084908.GA11580@infradead.org>
Date:	Mon, 21 Jul 2008 04:49:09 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Roland McGrath <roland@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/23] tracehook: exec

On Thu, Jul 17, 2008 at 12:28:20AM -0700, Roland McGrath wrote:
> This moves all the ptrace hooks related to exec into tracehook.h inlines.
> 
> This also lifts the calls for tracing out of the binfmt load_binary hooks
> into search_binary_handler() after it calls into the binfmt module.  This
> change has no effect, since all the binfmt modules' load_binary functions
> did the call at the end on success, and now search_binary_handler() does
> it immediately after return if successful.  We consolidate the repeated
> code, and binfmt modules no longer need to import ptrace_notify().

Care to first just consolidate the code from the binary handlers to
exec.c and then restrucure it?  Currently mainline doesn't even
have ptrace_event yet so it's hard to verify the code is the same.
It certainly isn't for binfmt_som although that's like just a bugfix
that needs to be documented.  Also the two new routines are too large
to be inlined, and I would rather not rely on the guarantee that no
other caller will pop up.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/