linux-kernel - Re: [PATCH 2/8] slub: Replace ctor field with ops field in /sys/slab/*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1216631318.19173.31.camel@penberg-laptop>
Date:	Mon, 21 Jul 2008 12:08:38 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	linux-kernel@...r.kernel.org, cl@...ux-foundation.org,
	akpm@...ux-foundation.org, riel@...hat.com
Subject: Re: [PATCH 2/8] slub: Replace ctor field with ops field in
	/sys/slab/*

Hi,

Pekka J Enberg <penberg@...helsinki.fi> writes:
> > +	if (s->ctor) {
> > +		x += sprintf(buf + x, "ctor : ");
> > +		x += sprint_symbol(buf + x, (unsigned long)s->ctor);
> > +		x += sprintf(buf + x, "\n");

On Sun, 2008-07-20 at 02:44 +0900, OGAWA Hirofumi wrote:
> How about new "%pS" like following for it? If CONFIG_KALLSYMS=n, it has
> difference though...
> 
> 		x += sprintf(buf + x, "ctor : %pS\n", (unsigned long)s->ctor);

Looks good to me. I'd prefer to wait until this patchset is merged and
do all of mm/slub.c in one go.

		Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/