linux-kernel - Re: [PATCH] V4L: Link tuner before saa7134

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6dd519ae0807210534k462858d6l13de6aaef29a4a9f@mail.gmail.com>
Date:	Mon, 21 Jul 2008 15:34:19 +0300
From:	"Brian Marete" <bgmarete@...il.com>
To:	"Simon Arlott" <simon@...e.lp0.eu>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-dvb@...uxtv.org
Subject: Re: [PATCH] V4L: Link tuner before saa7134

On Fri, Jul 18, 2008 at 2:51 PM, Simon Arlott <simon@...e.lp0.eu> wrote:
>
> On Fri, July 18, 2008 12:28, Brian Marete wrote:
>> On Jul 14, 6:00 am, hermann pitton <hermann-pit...@...or.de> wrote:
>>>
>>> #1 users can't set thetunertype anymore,
>>>    but the few cases oftunerdetection from eeprom we have should
>>>    work again for that price.
>>
>> Hello,
>>
>> Any patch yet for above issue? It seems to have made it into 2.6.26.
>>
>> I use saa7134 with everything, including the tuner modules, compiled
>> as a module. My card is detected as a flyvideo2000. The default tuner
>> for that card (#37) allows me to tune into TV but not to FM Radio. I
>> can access both functions (TV and FM Radio) if I override with
>> tuner=69, which is what I usually do. That override does not work on
>> 2.6.26.
>>
>> Any suggestions?
>
> Modify saa7134_board_init2 so that the manual tuner type setting isn't
> ignored. The first thing it does is to overwrite the current value
> (set earlier from module parameter) with the static values... even
> before trying to autodetect it.
>
> In saa7134-core.c saa7134_initdev:
>  dev->tuner_type   = saa7134_boards[dev->board].tuner_type;
> +dev->tuner_addr   = saa7134_boards[dev->board].tuner_addr;
>
> In saa7134-cards.c saa7134_board_init2:
> -dev->tuner_type   = saa7134_boards[dev->board].tuner_type;
> -dev->tuner_addr   = saa7134_boards[dev->board].tuner_addr;
>
> I think that will fix it.

And, indeed, it fixed it. I hope the patch will make it into the main-line.

Thanks.

-- 
B. Gitonga Marete
Tel: +254-722-151-590
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/