linux-kernel - Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721161307.GC13185@loki.buserror.net>
Date:	Mon, 21 Jul 2008 11:13:07 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Dave Jones <davej@...hat.com>,
	Kumar Gala <galak@...nel.crashing.org>,
	linuxppc-dev@...abs.org, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET

On Wed, Jul 16, 2008 at 05:57:45PM -0400, Dave Jones wrote:
> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
>  > On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
>  > > If we don't enable FS_ENET we get build issues:
>  > > 
>  > > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
>  > > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
>  > > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
>  > 
>  > How is this possible?  CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
> 
> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
> vmlinuz is trying to use a symbol which now lives in a module.

Yuck.  If FOO selects BAR, and FOO is 'y', then BAR should be 'y', not 'm'.
If BAR depends on other symbols that are 'm', they should be changed to 'y'.

-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/