linux-kernel - Re: [PATCH] Add dynamic MMC-over-SPI-GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Jul 2008 13:49:36 -0700
From:	David Brownell <david-b@...bell.net>
To:	Ben Nizette <bn@...sdigital.com>, Michael Buesch <mb@...sch.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Piot Skamruk <piotr.skamruk@...il.com>,
	Pierre Ossman <drzeus-mmc@...eus.cx>,
	openwrt-devel@...ts.openwrt.org
Subject: Re: [PATCH] Add dynamic MMC-over-SPI-GPIO driver

On Monday 14 July 2008, Ben Nizette wrote:
> 
> On Mon, 2008-07-14 at 21:09 +0200, Michael Buesch wrote:
> > This driver provides a sysfs interface to dynamically create
> > and destroy GPIO-based MMC/SD card interfaces.
> > So an MMC or SD card can be connected to generic GPIO pins
> > and be configured dynamically from userspace.
> 
> Can you use mmc-spi attached to spi-gpio and be done with it? 

Yes, that's how some of the early mmc-spi work was done.  ;)

> Sure you 
> won't have the dynamic alloc capability but you won't be reinventing the
> wheel either.  You don't have dynamic creation for any other platform
> device and if you need it then, IMO, it'd be better solved in a more
> generic way.
> 
> btw, what's this spi-gpio thing?  I can't see it in mainline except in a
> s3c24xx specific way.  My domestic blindness??

ISTR a patch for that, sitting somewhere in my mailbox waiting
for review cycles.  I've sent examples of such stuff around
before too.

I've held back submitting a spi-gpio driver until I could come
up with a way to configure it which would let the GPIO calls
get inlined ... because otherwise, there's a nasty speed penalty.

It's the difference between a function call per GPIO operation
and an instruction per GPIO operation.  Consider that each SPI
clock cycle requires four such operations, and GPIO function
calls often take 30 instructions ... there's a big penalty to
the non-inlined bitbangers, which is only partly addressed by
having those function calls sitting in I-cache.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/