linux-kernel - Re: [PATCH] ide: use proper printk() KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721214535.6de8c6a0@lxorguk.ukuu.org.uk>
Date:	Mon, 21 Jul 2008 21:45:35 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ide: use proper printk() KERN_* levels in ide-probe.c

On Mon, 21 Jul 2008 21:08:15 +0200
Bartlomiej Zolnierkiewicz <bzolnier@...il.com> wrote:

> While at it:
> 
> - fixup printk() messages in save_match() and hwif_init().
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> ---
>  drivers/ide/ide-probe.c |   54 ++++++++++++++++++++++++++----------------------
>  1 file changed, 30 insertions(+), 24 deletions(-)
> 
> Index: b/drivers/ide/ide-probe.c
> ===================================================================
> --- a/drivers/ide/ide-probe.c
> +++ b/drivers/ide/ide-probe.c
> @@ -141,7 +141,8 @@ static inline void do_identify (ide_driv
>  	 */
>  	if ((id->model[0] == 'P' && id->model[1] == 'M') ||
>  	    (id->model[0] == 'S' && id->model[1] == 'K')) {
> -		printk("%s: EATA SCSI HBA %.10s\n", drive->name, id->model);
> +		printk(KERN_ERR "%s: EATA SCSI HBA %.10s\n",
> +			drive->name, id->model);

That isn't an error. It occurs normally using legacy IDE with an EATA HBA
present in ATA emulating mode.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/