linux-kernel - Re: [patch 3/4] fastboot: make the raid autodetect code wait for all devices to init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 20 Jul 2008 14:33:02 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Neil Brown <neilb@...e.de>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	Simon Arlott <simon@...e.lp0.eu>,
	Daniel Walker <dwalker@...sta.com>,
	Rene Herman <rene.herman@...access.nl>
Subject: Re: [patch 3/4] fastboot: make the raid autodetect code wait for
 all devices to init

On Mon, 21 Jul 2008 14:30:12 +1000
Neil Brown <neilb@...e.de> wrote:

> 
> > +		while (driver_probe_done())
> >  			msleep(100);
> 
> That's worse.  Now it really looks like a boolean that is being used
> wrongly.  It seems that driver_probe_done either returns 0 or -EBUSY,
> so I'd prefer
> 
> > +		while (driver_probe_done() < 0)
> >  			msleep(100);
> 
> or even

ok I've done this one.

I'll be the first to say that this driver_probe_done() isn't very
elegant.. but it's out of my current scope to rewrite that whole
thing ... I'll leave that to GregKH.


-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/