linux-kernel - Re: [PATCH 9/22] ia64: Introducing asm/syscalls.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216617584.2705.1.camel@jaswinder.satnam>
Date:	Mon, 21 Jul 2008 10:49:44 +0530
From:	Jaswinder Singh <jaswinder@...radead.org>
To:	Matthew Wilcox <matthew@....cx>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernelnewbies <kernelnewbies@...linux.org>,
	David Woodhouse <dwmw2@...radead.org>, tony.luck@...el.com,
	linux-ia64@...r.kernel.org
Subject: Re: [PATCH 9/22] ia64: Introducing asm/syscalls.h

Hello Matthew,

On Sun, 2008-07-20 at 18:19 -0600, Matthew Wilcox wrote:
> On Mon, Jul 21, 2008 at 05:03:55AM +0530, Jaswinder Singh wrote:
> > Declaring arch-dependent syscalls for ia64 architecture
> > +#ifndef CONFIG_PCI
> > +asmlinkage long sys_pciconfig_read(unsigned long, unsigned long,
> > +				   unsigned long, unsigned long, void *);
> > +asmlinkage long sys_pciconfig_write(unsigned long, unsigned long,
> > +				    unsigned long, unsigned long, void *);
> > +#endif /* CONFIG_PCI */
> 
> These are already declared in linux/syscalls.h
> 
> And frankly, we should just make these return -ENOSYS always.  Any
> software that uses them is stuffed on machines with multiple domains.
> 

diff --git a/include/asm-ia64/syscalls.h b/include/asm-ia64/syscalls.h
index 71af530..8799e14 100644
--- a/include/asm-ia64/syscalls.h
+++ b/include/asm-ia64/syscalls.h
@@ -28,11 +28,5 @@ asmlinkage unsigned long sys_mmap2(unsigned long, unsigned long,
 				   int, int, int, long);
 asmlinkage unsigned long sys_mmap(unsigned long, unsigned long,
 				  int, int, int, long);
-#ifndef CONFIG_PCI
-asmlinkage long sys_pciconfig_read(unsigned long, unsigned long,
-				   unsigned long, unsigned long, void *);
-asmlinkage long sys_pciconfig_write(unsigned long, unsigned long,
-				    unsigned long, unsigned long, void *);
-#endif /* CONFIG_PCI */
 
 #endif /* _ASM_IA64_SYSCALLS_H */

Thank you,

Jaswinder Singh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/