linux-kernel - Re: [PATCH 0/22] Introducing asm/syscalls.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721055459.GD24246@parisc-linux.org>
Date:	Sun, 20 Jul 2008 23:55:00 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	kernelnewbies <kernelnewbies@...linux.org>,
	David Woodhouse <dwmw2@...radead.org>, rth@...ddle.net,
	rmk@....linux.org.uk, hskinnemoen@...el.com, cooloney@...nel.org,
	starvik@...s.com, dhowells@...hat.com, ysato@...rs.sourceforge.jp,
	tony.luck@...el.com, takata@...ux-m32r.org, geert@...ux-m68k.org,
	ralf@...ux-mips.org, schwidefsky@...ibm.com, lethal@...ux-sh.org,
	chris@...kel.net
Subject: Re: [PATCH 0/22] Introducing asm/syscalls.h

On Mon, Jul 21, 2008 at 11:15:00AM +0530, Jaswinder Singh wrote:
> It may be useless for you but it looks useful for me.
> If you go though all syscalls patches only then you will figure it out
> syscalls are moving in many files for many architecture.
> 
> There can be many reasons to add syscalls.h, few of them are :-
> 1. Declaring syscalls functions before they get used is a nice habit and
> will quite also quiet sparse.
> 
> 2. Declaring all arch dependent syscalls under one roof is nice for
> future enhancement for kernel developers as they can see what is defined
> in other architectures and try to follow same prototype as far as
> possible, Then it will be really useful for everyone. And then we can
> move common arch dependent syscalls in one place.
> 
> 3. ???Declaring all arch dependent syscalls under one roof is nice for
> user for reference purpose.

I think it makes more sense to add them to linux/syscall.h, possibly
with comments mentioning which architectures implement them.

If there are architectures with different prototypes for the same
syscall, using an ifdef CONFIG_(arch) is /better/ annotation that having
them in different header files.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/