linux-kernel - Re: [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1216620962.29890.3.camel@pek-cluo>
Date:	Mon, 21 Jul 2008 14:16:02 +0800
From:	Chunbo Luo <chunbo.luo@...driver.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, jeff@...zik.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH]: libata-scsi: Don't start hotplug work queue
	if	hotplug is	disabled

On Mon, 2008-07-21 at 13:40 +0900, Tejun Heo wrote:
> Chunbo Luo wrote:
> >> And this message has nothing to do with SCSI.  It's printed by libata
> >> proper for several drivers which don't support ATAPI.  Did the patch
> >> really kill the warning messages?  Can you please post full boot log
> >> from 2.6.26 w/o the patch?
> > 
> > If the drivers don't support ATAPI, the hotplug task cannot find linked device,
> > and it will start the hotplug task again. Which will print messages continously 
> > like this.
> > 
> > ----------
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> > ...
> > ------------
> > 
> > We should find a way to avoid this kind of noisy warning messages.
> > 
> > This patch cannot kill the warning messages, but it can avoid the
> > duplicate warning messages.
> 
> Hmmm... yeah, indeed.  That check is located at rather strange place.
> Can you please test the attached patch?

I tested the attached patch on mpc7448hpc2 ,it worked. It can avoid the
multiple warning messages.

Thanks!
Chunbo
> 
> Thanks.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/