linux-kernel - Re: [PATCH] x86: add apic probe for genapic 64bit v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080722071324.GA2664@elte.hu>
Date:	Tue, 22 Jul 2008 09:13:24 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Jack Steiner <steiner@....com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: add apic probe for genapic 64bit v2


* Ingo Molnar <mingo@...e.hu> wrote:

> > v2: fix compiling when CONFIG_ACPI is not set
> 
> applied to tip/x86/x2apic - thanks Yinghai.
> 
> > +static struct genapic *apic_probe[] __initdata = {
> > +	&apic_x2apic_uv_x,
> > +	&apic_x2apic_phys,
> > +	&apic_x2apic_cluster,
> > +	&apic_physflat,
> > +	NULL,
> > +};
> 
> very nice generalization!

btw.:

   apic_probe[i]->acpi_madt_oem_check

should probably be renamed to something more neutral like "->probe" - 
there's nothing ACPI about it and some weird boxes could use PCI or 
other probing mechanisms to discover the type of APIC they want to use.

plus i guess genapic_32.h and genapic_64.h should be unified and struct 
apic_ops should be put into struct genapic?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/