linux-kernel - Re: [PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216717739.7257.94.camel@twins>
Date:	Tue, 22 Jul 2008 11:08:59 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	roel kluin <roel.kluin@...il.com>
Cc:	mingo@...e.hu, rml@...h9.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] sched: test below 0 on unsigned
	sysctl_sched_rt_period

On Mon, 2008-07-21 at 20:28 -0400, roel kluin wrote:
> Peter, you added the test in global_rt_runtime(), in commit
> d0b27fa77854b149ad4af08b0fe47fe712a47ade
> could you take a look at it and tell whether this test should
> be replaced by something else?
> 
> The patch was only checkpatch tested
> ---
> sysctl_sched_rt_period is unsigned so the test doesn't work.
> state_filter is an unsigned long so the test didn't work
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/kernel/sched.c b/kernel/sched.c
> index 99e6d85..2030340 100644
> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -832,9 +832,6 @@ static inline u64 global_rt_period(void)
>  
>  static inline u64 global_rt_runtime(void)
>  {
> -	if (sysctl_sched_rt_period < 0)
> -		return RUNTIME_INF;

Gah, I'm a moron. That should read:

  if (sysctl_sched_rt_runtime < 0)

Care to send a patch to fix it?

Thanks for spotting this!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/