linux-kernel - Re: [Patch] um: fix a build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080722105812.GB5283@alice>
Date:	Tue, 22 Jul 2008 12:58:12 +0200
From:	Eric Sesterhenn <snakebyte@....de>
To:	xiyou.wangcong@...il.com
Cc:	alan@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net, jdike@...toit.com
Subject: Re: [Patch] um: fix a build error

I just ran across the same build error, does
something like this look reasonable? Only build
and boot tested.

This fixes the following build error:

  CC      arch/um/drivers/line.o
  arch/um/drivers/line.c: In function ‘line_write_interrupt’:
  arch/um/drivers/line.c:366: error: ‘struct tty_ldisc’ has no member
  named ‘write_wakeup’
  arch/um/drivers/line.c:367: error: ‘struct tty_ldisc’ has no member
  named ‘write_wakeup’
  make[1]: *** [arch/um/drivers/line.o] Error 1
  make: *** [arch/um/drivers] Error 2


Signed-off-by: Eric Sesterhenn <snakebyte@....de>

--- linux-2.6/arch/um/drivers/line.c.orig	2008-07-22 12:06:17.000000000 +0200
+++ linux-2.6/arch/um/drivers/line.c	2008-07-22 12:06:49.000000000 +0200
@@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt(
 	if (tty == NULL)
 		return IRQ_NONE;
 
-	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) &&
-	   (tty->ldisc.write_wakeup != NULL))
-		(tty->ldisc.write_wakeup)(tty);
-
+	if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags))
+		tty_wakeup(tty);
 	/*
 	 * BLOCKING mode
 	 * In blocking mode, everything sleeps on tty->write_wait.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/