linux-kernel - [PATCH] istallion: Small follow up for the fixes to istallion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080722134414.19a14ca7@lxorguk.ukuu.org.uk>
Date:	Tue, 22 Jul 2008 13:44:14 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Wang Chen <wangchen@...fujitsu.com>
Cc:	Alan Cox <alan@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] istallion: Small follow up for the fixes to istallion

> Fix the compile error which was caused by commit "istallion: use tty_port" and "tty: Ldisc revamp".
> Also make the warning silent.

Sorry about that one.

There is a bit more fixing needed as the ldisc reference isn't held
during close. 

--

istallion: Use helpers

From: Alan Cox <alan@...hat.com>

The ldisc needs to be referenced properly when used. The tty layer has a
helper for this which should have been used but this driver got missed
originally.

Signed-off-by: Alan Cox <alan@...hat.com>
---

 drivers/char/istallion.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)


diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
index 63d22b5..f9ebcd4 100644
--- a/drivers/char/istallion.c
+++ b/drivers/char/istallion.c
@@ -925,8 +925,7 @@ static void stli_close(struct tty_struct *tty, struct file *filp)
 	clear_bit(ST_TXBUSY, &portp->state);
 	clear_bit(ST_RXSTOP, &portp->state);
 	set_bit(TTY_IO_ERROR, &tty->flags);
-	if (tty->ldisc.ops->flush_buffer)
-		(tty->ldisc.ops->flush_buffer)(tty);
+	tty_ldisc_flush(tty);
 	set_bit(ST_DOFLUSHRX, &portp->state);
 	stli_flushbuffer(tty);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/