linux-kernel - Re: [PATCH] hid: wellspring device quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4885E13E.1010607@euromail.se>
Date:	Tue, 22 Jul 2008 15:31:42 +0200
From:	Henrik Rydberg <rydberg@...omail.se>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>, robfitz@...k.net,
	akpm@...l.org, Vojtech Pavlik <vojtech@...e.cz>,
	dmonakhov@...nvz.org
Subject: Re: [PATCH] hid: wellspring device quirks

Jiri Kosina wrote:
> On Sun, 13 Jul 2008, Henrik Rydberg wrote:
> 
>> This patch adds the HID_QUIRK_IGNORE_MOUSE quirk for the Apple USB
>> multitouch devices based on BCM5974, aka Wellspring. These devices
>> will instead be picked up by the new bcm5974 driver.
> 
> Hi Henrik,
> 
> is the mouse not working at all with standard HID driver?
> 

Yes, it is working out-of-the-box, only poorly.

> I'd prefer to postpone merging this patch until bcm5974 hits mainline if
> the device works in a limited way with standard HID driver, so that we
> don't introduce regression.
> 

Absolutely, this patch should be applied together with the bcm5974 driver,
or not be applied. The driver patch is here:

http://userweb.kernel.org/~akpm/mmotm/broken-out/input-bcm5974-055-smoother-motion-irq-simplification.patch

> If the device doesn't work with HID driver at all though, it is probably
> perfectly fine to merge it right away. Please let me know, I have no
> knowledge about this particular device.

It is fine to leave it, but I would of course prefer to have the driver included together with this patch.

Thanks!
Henrik Rydberg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/