linux-kernel - Re: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfd18e0f0807220746k41ff209bgc099a83042e38086@mail.gmail.com>
Date:	Tue, 22 Jul 2008 16:46:41 +0200
From:	"Michael Kerrisk" <mtk.manpages@...glemail.com>
To:	"Oleg Nesterov" <oleg@...sign.ru>
Cc:	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Roland McGrath" <roland@...hat.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, andi@...stfloor.org
Subject: Re: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded

On Tue, Jul 22, 2008 at 3:02 PM, Oleg Nesterov <oleg@...sign.ru> wrote:
> On 07/22, Michael Kerrisk wrote:
>>
>> On Tue, Jul 22, 2008 at 2:43 PM, Oleg Nesterov <oleg@...sign.ru> wrote:
>> >
>> > That said, this is the user-visible change...
>>
>> True.  Not sure how important that is in this case though.  What is
>> the reason for making this change (other than tidiness)?
>
> Tidiness is the only reason.
>
> Please don't hesitate to nack this patch if you think we shouldn't
> change the historical behaviour, the cleanup is very minor.

It is hard to think of something that might break because of this, so
I'll remain silent.

> As for me, I think it is a bit strange we append "%.pid" depending on
> is_multithreaded, the same app can have 1 or more threads for various

Agreed.  It is strange.

Cheers,

Michael

> reasons when the coredump happens, but this behaviour is very old and
> perhaps it is too late to change.
>
> Oleg.
>
>



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/