linux-kernel - Re: [PATCH] firewire: fw-ohci: TSB43AB22/A dualbuffer workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2008 18:11:26 -0400
From:	Jarod Wilson <jwilson@...hat.com>
To:	linux1394-devel@...ts.sourceforge.net
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: fw-ohci: TSB43AB22/A dualbuffer workaround

On Tuesday 22 July 2008 12:41:10 pm Stefan Richter wrote:
> Isochronous reception in dualbuffer is reportedly broken with
> TI TSB43AB22A on x86-64.  Descriptor addresses above 2G have been
> determined as the trigger:
> https://bugzilla.redhat.com/show_bug.cgi?id=435550
>
> Two fixes are possible:
>   - pci_set_consistent_dma_mask(pdev, DMA_31BIT_MASK);
>     at least when IR descriptors are allocated, or
>   - simply don't use dualbuffer.
> This fix implements the latter workaround.
>
> But we keep using dualbuffer on x86-32 which won't give us highmen (and
> thus physical addresses outside the 31bit range) in coherent DMA memory
> allocations.  Right now we could for example also whitelist PPC32, but
> DMA mapping implementation details are expected to change there.
>
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>

Still hoping we can get some confirmation of a chipset bug or a fix from TI 
for this controller, but in the interim, this seems to be the most reasonable 
route to go right now.

Signed-off-by: Jarod Wilson <jwilson@...hat.com>

-- 
Jarod Wilson
jwilson@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/