lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Jul 2008 06:19:14 +0200 From: Krzysztof Helt <krzysztof.h1@...zta.fm> To: Julia Lawall <julia@...u.dk> Cc: adaplas@...il.com, linux-fbdev-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [Linux-fbdev-devel] [PATCH 6/7] drivers/video: Release mutex in error handling code On Mon, 21 Jul 2008 09:58:55 +0200 (CEST) Julia Lawall <julia@...u.dk> wrote: > From: Julia Lawall <julia@...u.dk> > > The mutex is released on a successful return, so it would seem that it > should be released on an error return as well. > > The semantic patch finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @@ > expression l; > @@ > > mutex_lock(l); > ... when != mutex_unlock(l) > when any > when strict > ( > if (...) { ... when != mutex_unlock(l) > + mutex_unlock(l); > return ...; > } > | > mutex_unlock(l); > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@...u.dk> > > --- Acked-by: Krzysztof Helt <krzysztof.h1@...pl> ---------------------------------------------------------------------- Partyjka w Chinczyka? Graj >>> http://link.interia.pl/f1e67 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists