linux-kernel - Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080722162751.e8584d46.akpm@linux-foundation.org>
Date:	Tue, 22 Jul 2008 16:27:51 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-kernel@...r.kernel.org, g.liakhovetski@...gutronix.de,
	Greg KH <greg@...ah.com>
Subject: Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)

On Thu, 12 Jun 2008 11:53:36 -0700
David Brownell <david-b@...bell.net> wrote:

> This adds a simple sysfs interface for GPIOs.

device_create_drvdata() has magically vanished from today's linux-next,
so this code doesn't compile any more.

This:

--- a/drivers/gpio/gpiolib.c~gpio-sysfs-interface-updated-gpio-linux-next-fixes-for-sysfs-support-fix
+++ a/drivers/gpio/gpiolib.c
@@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire
 	if (status == 0) {
 		struct device	*dev;
 
-		dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0,
-				desc, "gpio%d", gpio);
+		dev = device_create(&gpio_class, desc->chip->dev, 0, desc,
+					"gpio%d", gpio);
 		if (dev) {
 			if (direction_may_change)
 				status = sysfs_create_group(&dev->kobj,
@@ -537,8 +537,8 @@ static int gpiochip_export(struct gpio_c
 
 	/* use chip->base for the ID; it's already known to be unique */
 	mutex_lock(&sysfs_lock);
-	dev = device_create_drvdata(&gpio_class, chip->dev, 0, chip,
-			"gpiochip%d", chip->base);
+	dev = device_create(&gpio_class, chip->dev, 0, chip, "gpiochip%d",
+				chip->base);
 	if (dev) {
 		status = sysfs_create_group(&dev->kobj,
 				&gpiochip_attr_group);
_

seems to compile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/