linux-kernel - [PATCH 0/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2008 10:18:41 -0700
From:	Mike Travis <travis@....com>
To:	Ingo Molnar <mingo@...e.hu>, Rusty Russell <rusty@...tcorp.com.au>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>, Jack Steiner <steiner@....com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map


The following patch is submitted to resolve this problem...

(Based on tip/master.  I will generate a linux-next version if requested
since it now has generic code that will be executed for non-x86 arch's.)

> * Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> >> > > I wouldn't mind it at all, and since it's almost always calling a 
> >> > > function that requires a cpumask_t pointer (like the cpu_* ops or 
> >> > > set_cpus_allowed_ptr) then there shouldn't be too many "pointer 
> >> > > dereference" penalties.  I'm just always a bit hesitant to make too 
> >> > > many generic changes since I have only x86 and ia64 machines to test 
> >> > > with.
> > > 
> > > The simple version is just a static array of [NR_CPUS] cpumask_t's.  
> > > Do that, with an override for smarter archs?
> > > 
> > > I really REALLY prefer that over the fairly tortuous macros.
> 
> a fresh commit in -git has exposed the topology.h mess - see the hack 
> below. We now have diverging versions of topology_core_siblings() 
> semantics - that sure cannot be right. Mike?
> 
> 	Ingo
> 
> ------->
> commit 695a6b456307455a10059512208e8ed0d376ecd3
> Author: Ingo Molnar <mingo@...e.hu>
> Date:   Wed Jul 23 13:19:44 2008 +0200
> 
>     topology: work around topology_core_siblings() breakage
>     
>     work around:
>     
>     drivers/net/sfc/efx.c: In function ā??efx_probe_interrupts':
>     drivers/net/sfc/efx.c:845: error: lvalue required as unary ā??&' operand
>     
>     the topology API is a mess right now ...
>     
>     Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---

Signed-off-by: Mike Travis <travis@....com>

---
The following cross built successfully:

    x86_64-default
    x86_64-single
    x86_64-8psmp
    x86_64-debug
    x86_64-numa
    i386-default
    i386-single
    i386-smp
    ia64-sn2
    ia64-default
    ia64-nosmp
    ia64-zx1
    s390-default
    arm-default
    sparc-default
    sparc64-default
    sparc64-smp
    mips-default
    ppc-pmac32

These had problems:

    ppc-iseries
	 Build failed Wed Jul 23 10:10:10 PDT 2008
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
    ppc64
	 Build failed Wed Jul 23 10:10:19 PDT 2008
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
    ppc-pseries
	 Build failed Wed Jul 23 10:10:29 PDT 2008
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
    ppc-smp
	 Build failed Wed Jul 23 10:12:03 PDT 2008
	  CC      drivers/scsi/scsi_error.o
	  BOOTCC  arch/powerpc/boot/libfdt/fdt_strerror.o
	make[1]: *** [arch/powerpc/boot/uImage] Error 127
    ps3_defconfig
	 Build failed Wed Jul 23 10:12:18 PDT 2008
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
    powerpc-allmodconfig
	 Build failed Wed Jul 23 10:12:31 PDT 2008
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration
	:0: error: -m64 not supported in this configuration

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/