linux-kernel - Re: [PATCH] x86: usb debug port early console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080723133601.5a7bc494.akpm@linux-foundation.org>
Date:	Wed, 23 Jul 2008 13:36:01 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com,
	andi@...stfloor.org, arjan@...radead.org, ebiederm@...ssion.com,
	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: usb debug port early console

On Wed, 23 Jul 2008 13:18:12 -0700
"Yinghai Lu" <yhlu.kernel@...il.com> wrote:

> > Please always pass all patches through scripts/checkpatch.pl.

What I meant was to use checkpatch and then to actually read its
output ;)

> yhlu@...ux-zpir:~/xx/xx/kernel/tip/linux-2.6> ./scripts/checkpatch.pl
> patches/9xxx.patch
> WARNING: line over 80 characters
> #319: FILE: arch/x86/kernel/early_printk.c:420:
> +       if (!(read_pci_config_16(num, slot, func, PCI_STATUS) &
> PCI_STATUS_CAP_LIST))
> 
> WARNING: line over 80 characters
> #330: FILE: arch/x86/kernel/early_printk.c:431:
> +               pos = read_pci_config_byte(num, slot, func,
> pos+PCI_CAP_LIST_NEXT);
> 
> WARNING: line over 80 characters
> #335: FILE: arch/x86/kernel/early_printk.c:436:
> +static __u32 __init find_dbgp(int ehci_num, unsigned *rbus, unsigned
> *rslot, unsigned *rfunc)
> 
> WARNING: line over 80 characters
> #344: FILE: arch/x86/kernel/early_printk.c:445:
> +                               class = read_pci_config(bus, slot,
> func, PCI_CLASS_REVISION);
> 
> WARNING: line over 80 characters
> #347: FILE: arch/x86/kernel/early_printk.c:448:
> +                               cap = find_cap(bus, slot, func,
> PCI_CAP_ID_EHCI_DEBUG);
> 
> WARNING: line over 80 characters
> #386: FILE: arch/x86/kernel/early_printk.c:487:
> +                               portsc =
> readl(&ehci_regs->port_status[port - 1]);

I don't think the 80-col warnigns should necessarily all be fixed.  But
one should take a look at the code and ask "did I really need to do it
that way?".

> WARNING: externs should be avoided in .c files
> #425: FILE: arch/x86/kernel/early_printk.c:526:
> +void early_printk(const char *fmt, ...);

This one is a must-fix.

> WARNING: consider using strict_strtoul in preference to simple_strtoul
> #518: FILE: arch/x86/kernel/early_printk.c:619:
> +               dbgp_num = simple_strtoul(s, &e, 10);

simple_strtoul() is sometimes OK for kernel parameters, sometimes
strict_strtoul() is better.

> WARNING: externs should be avoided in .c files
> #722: FILE: arch/x86/kernel/head64.c:75:
> +extern void __init enable_debug_console(char *buf);

This one also should be fixed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/