linux-kernel - Re: [PATCH] set_irq_wake: fix return code and wake status tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807232044.15049.ioe-lkml@rameria.de>
Date:	Wed, 23 Jul 2008 20:44:14 +0200
From:	Ingo Oeser <ioe-lkml@...eria.de>
To:	Uwe Kleine-König <Uwe.Kleine-Koenig@...i.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] set_irq_wake: fix return code and wake status tracking

Hi Uwe,

you can mark the new function static.

[trimmed CC list, since this is just a minor issue]

On Wednesday 23 July 2008, Uwe Kleine-König wrote:
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index e01ad8e..227cd49 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -194,6 +194,17 @@ void enable_irq(unsigned int irq)
>  }
>  EXPORT_SYMBOL(enable_irq);
>  
> +int set_irq_wake_real(unsigned int irq, unsigned int on)
static int set_irq_wake_real(unsigned int irq, unsigned int on)

> +{
> +	struct irq_desc *desc = irq_desc + irq;
> +	int ret = -ENXIO;
> +
> +	if (desc->chip->set_wake)
> +		ret = desc->chip->set_wake(irq, on);
> +
> +	return ret;
> +}
> +

Best Regards

Ingo Oeser
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/