linux-kernel - Re: [PATCH] x86: usb debug port early console v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440807231646t11313612x4107c2c780d2b0f9@mail.gmail.com>
Date:	Wed, 23 Jul 2008 16:46:36 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Greg KH" <greg@...ah.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Andi Kleen" <andi@...stfloor.org>,
	"Arjan van de Ven" <arjan@...radead.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: usb debug port early console v2

On Wed, Jul 23, 2008 at 4:21 PM, Greg KH <greg@...ah.com> wrote:
> On Wed, Jul 23, 2008 at 03:54:09PM -0700, Yinghai Lu wrote:
>> On Wed, Jul 23, 2008 at 3:45 PM, Greg KH <greg@...ah.com> wrote:
>> > On Wed, Jul 23, 2008 at 02:00:53PM -0700, Yinghai Lu wrote:
>> >> --- linux-2.6.orig/drivers/usb/host/ehci.h
>> >> +++ linux-2.6/drivers/usb/host/ehci.h
>> >
>> > I don't understand the issue of any of these #ifdefs here.  Why are they
>> > needed?
>>
>> In file included from arch/x86/kernel/early_printk.c:19:
>> arch/x86/kernel/../../../drivers/usb/host/ehci.h:109: error: field
>> 'iaa_watchdog' has incomplete type
>
> Ah, so you are papering over the real problem here, right?
>
> Why not just include the properly needed #includes either where you are
> including this header file, or add the dependancies to the ehci.h file
> itself (which is usually preferred.)

how about moving

struct ehci_caps;
struct ehci_regs;
struct ehci_dbg_port;

to one header file in include/usb
so could use
#include <linux/usb/ehci_def.h>
instead of
#include "../../../drivers/usb/host/ehci.h"

>
>> > And shouldn't there be a separate config option for early printk through
>> > the ehci debug port?
>>
>> under usb or processor?
>
> Somewhere.
>
> Also, usb patches should be cc:ed to the linux-usb mailing list.  I'm
> sure the EHCI authors would like to comment on this patch...

oh, i thought you wrote the ehci code.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/