linux-kernel - Re: [PATCH] cifs: avoid mixing bool and le16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216859051.30386.40.camel@brick>
Date:	Wed, 23 Jul 2008 17:24:11 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Steve French <smfrench@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: avoid mixing bool and le16

On Wed, 2008-07-23 at 19:19 -0500, Steve French wrote:
> Seems like a cast to bool or an "if ...else" would be clearer than using !!
> By the way I don't see this warning - is it a newer compiler warning?
> 

Sorry, sometimes I forget to say sparse warning.  This is with
__CHECK_ENDIAN__ as well.

Would you prefer:
	if (pSMBr->hdr.Flags2 & SMBFLG2_UNICODE)
		is_unicode = true;
	else
		is_unicode = false;

Instead?

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/