linux-kernel - Re: [PATCH]: PCI: GART iommu alignment fixes [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080724123755.GP31439@8bytes.org>
Date:	Thu, 24 Jul 2008 14:37:55 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	prarit@...hat.com, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, jbarnes@...tuousgeek.org,
	ed.pollard@....com, epollard@...hat.com
Subject: Re: [PATCH]: PCI: GART iommu alignment fixes [v2]

On Thu, Jul 24, 2008 at 07:34:35PM +0900, FUJITA Tomonori wrote:
> On Thu, 24 Jul 2008 06:09:31 -0400
> Prarit Bhargava <prarit@...hat.com> wrote:
> >         skge->mem = pci_alloc_consistent(hw->pdev, skge->mem_size, 
> > &skge->dma);
> >         if (!skge->mem)
> >                 return -ENOMEM;
> > 
> >         BUG_ON(skge->dma & 7);
> > 
> >         if ((u64)skge->dma >> 32 != ((u64) skge->dma + skge->mem_size) 
> >  >> 32) {
> >                 printk(KERN_ERR PFX "pci_alloc_consistent region crosses 
> > 4G boundary\n");
> >                 err = -EINVAL;
> >                 goto free_pci_mem;
> >         }
> > 
> > 
> > If pci_alloc_consistent did the "right" thing, we should *never* see 
> > that warning message.
> 
> Well, I think that this is not releated with the pci_alloc_consistent
> alignment problem that you talk about.
> 
> I think that the driver tries to avoid 4GB boundary crossing
> problem. You can find some work to avoid this, for example:
> 
> http://www.ussg.iu.edu/hypermail/linux/kernel/0712.0/2206.html
> 
> pci_device_add() has the following code to avoid this:
> 
> pci_set_dma_seg_boundary(dev, 0xffffffff);
> 
> I suspect that the problem you talk about, alloc_consistent doesn't
> return the reqeuested size aligned memory, breaks anything.

But I think Prarit is right with this change. If the interface defines
this behavior the IOMMU drivers have to implement it. I am just
wondering that the problem never showed up before. The GART driver is a
few years old now.

Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/