linux-kernel - Re: [RFC: 2.6 patch] clarify the WIRELESS_EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2008 14:54:48 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Pierre Ossman <drzeus-list@...eus.cx>,
	"John W. Linville" <linville@...driver.com>,
	Jean Tourrilhes <jt@....hp.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC: 2.6 patch] clarify the WIRELESS_EXT_SYSFS help text

On Thu, 2008-07-24 at 15:42 +0300, Adrian Bunk wrote:
> On Thu, Jul 24, 2008 at 01:38:40PM +0200, Johannes Berg wrote:
> > On Thu, 2008-07-24 at 11:58 +0200, Pierre Ossman wrote:
> > > From commit 22bb1be4d27...:
> > > 
> > > "The /sys/class/net/*/wireless/ direcory is, as far as I know, not used
> > > by anyone."
> > > 
> > > Can't have been much of an investigation as HAL uses these to determine
> > > if a card is a wireless one. Without this option, you cannot get
> > > wireless support in NetworkManager, stranding most laptops.
> > 
> > Bzzzzt. You suck. Go check again. Hint: try hal's git tree.
> 
> Can everyone agree on the patch below?
> 
> > johannes
> 
> cu
> Adrian
> 
> 
> <--  snip  -->
> 
> 
> Current Hal uses the CONFIG_WIRELESS_EXT_SYSFS files, so don't claim 
> there were no known users and recommend to enable the option.
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> b685f62718b947264657c298e5ee5b2149200f68 
> diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
> index ab015c6..e582432 100644
> --- a/net/wireless/Kconfig
> +++ b/net/wireless/Kconfig
> @@ -39,4 +39,4 @@ config WIRELESS_EXT_SYSFS
>  	  files in /sys/class/net/*/wireless/. The same information
>  	  is available via the ioctls as well.
>  
> -	  Say Y if you have programs using it (we don't know of any).
> +	  If unsure, say Y.

Maybe also add:

   "HAL <= 0.5.11 depends on this feature."

Where I hope I got the version number right :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/