linux-kernel - Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080725.012748.108121457.anemo@mba.ocn.ne.jp>
Date:	Fri, 25 Jul 2008 01:27:48 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	jason.wessel@...driver.com
Cc:	linux-kernel@...r.kernel.org, ralf@...ux-mips.org,
	linux-mips@...ux-mips.org
Subject: Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb
 core

On Fri, 18 Jul 2008 12:08:47 -0500, Jason Wessel <jason.wessel@...driver.com> wrote:
> diff --git a/include/asm-mips/kgdb.h b/include/asm-mips/kgdb.h
...
> +static inline void arch_kgdb_breakpoint(void)
> +{
> +	__asm__ __volatile__(
> +		".globl breakinst\n\t"
> +		".set\tnoreorder\n\t"
> +		"nop\n"
> +		"breakinst:\tbreak\n\t"
> +		"nop\n\t"
> +		".set\treorder");
> +}

The gcc might inline kgdb_breakpoint() which includes
arch_kgdb_breakpoint().  I got this error with gcc 4.3.1:

  CC      kernel/kgdb.o
{standard input}: Assembler messages:
{standard input}:809: Error: symbol `breakinst' is already defined
{standard input}:913: Error: symbol `breakinst' is already defined
{standard input}:1233: Error: symbol `breakinst' is already defined

Moving arch_kgdb_breakpoint() into arch/mips/kernel/kgdb.c should
solve the problem.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/