| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080724032627.GA36603@sgi.com> Date: Wed, 23 Jul 2008 22:26:28 -0500 From: Jack Steiner <steiner@....com> To: Nick Piggin <npiggin@...e.de> Cc: Andrew Morton <akpm@...ux-foundation.org>, Linux Memory Management List <linux-mm@...ck.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: GRU driver feedback On Wed, Jul 23, 2008 at 04:12:30PM +0200, Nick Piggin wrote: > > Hi Jack, > > Some review of the GRU driver. Hope it helps. Some trivial. Thanks for the feedback. I'm at OLS this week & barely reading email. I'll go thru the comments as soon as I get home next week & will respond in detail then. > > - I would put all the driver into a single patch. It's a logical change, > and splitting them out is not really logical. Unless for example you > start with a minimally functional driver and build more things on it, > I don't think there is any point avoiding the one big patch. You have to > look at the whole thing to understand it properly anyway really. I would prefer that, too, but was told by one of the more verbose kernel developers (who will remain nameless) that I should split the code into multiple patches to make it easier to review. Oh well..... More responses to follow.... --- jack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists