linux-kernel - Re: post 2.6.26 requires pciehp_slot_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807241506.58973.jbarnes@virtuousgeek.org>
Date:	Thu, 24 Jul 2008 15:06:58 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Pierre Ossman <drzeus-list@...eus.cx>
Cc:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-pci@...r.kernel.org
Subject: Re: post 2.6.26 requires pciehp_slot_with_bus

On Thursday, July 24, 2008 2:51 pm Pierre Ossman wrote:
> On Thu, 24 Jul 2008 14:07:18 -0700
>
> Jesse Barnes <jbarnes@...tuousgeek.org> wrote:
> > On Thursday, July 24, 2008 1:39 pm Pierre Ossman wrote:
> > > This is a laptop with a single expressport that worked fine up until
> > > this merge window. What changed and why is it no longer possible to
> > > support this hardware without a kernel parameter?
> >
> > Yeah we're being a bit more careful about registering hotplug slots these
> > days.  The fact that you got a conflict message indicates that more than
> > one driver is trying to bind to that PCIe port and handle hotplug for it.
> >  I guess acpiphp must already be loaded?
>
> Nope. Only pciehp is builtin, and acpiphp is not loaded. Anything
> non-hotplug related that can block stuff?

Theoretically only one of the other hotplug drivers could claim the slot (e.g. 
acpi, cpci, cpqhp, fakephp etc.).  You could put a dump_stack() or something 
into drivers/pci/hotplug/pci_hotplug_core.c:pci_hp_register to see if we're 
getting multiple callers on the same slot for some reason...  Maybe the 
pciehp driver itself is trying to register the same slot twice?

> Anyway, the port seems to work even with that warning present though
> (sorry for not testing that properly earlier). Stray warnings is still
> not pleasant though, so I can do some more testing if you have some
> ideas.

Thanks.  Yeah we don't want to scare people or break existing setups.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/