linux-kernel - Re: [PATCH -next] kmemcheck: include module.h to prevent warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216942023.12392.17.camel@penberg-laptop>
Date:	Fri, 25 Jul 2008 02:27:03 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, vegardno@....uio.no,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] kmemcheck: include module.h to prevent warnings

On Thu, 2008-07-24 at 16:09 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> kmemcheck/shadow.c needs to include <linux/module.h> to prevent
> the following warnings:
> 
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Looks good to me.

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> ---
>  arch/x86/mm/kmemcheck/shadow.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20080724.orig/arch/x86/mm/kmemcheck/shadow.c
> +++ linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c
> @@ -1,5 +1,6 @@
>  #include <linux/kmemcheck.h>
>  #include <linux/mm.h>
> +#include <linux/module.h>
>  
>  #include <asm/page.h>
>  #include <asm/pgtable.h>
> 
> 
> ---
> ~Randy
> Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
> http://linuxplumbersconf.org/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/