linux-kernel - Re: [PATCH] usb: move ehci reg def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807241757.23441.david-b@pacbell.net>
Date:	Thu, 24 Jul 2008 17:57:22 -0700
From:	David Brownell <david-b@...bell.net>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	"Arjan van de Ven" <arjan@...radead.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Greg KH" <greg@...ah.com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: move ehci reg def

On Thursday 24 July 2008, Yinghai Lu wrote:
> 
> prepare x86: usb debug port early console
> 
> move ehci struct def to linux/usrb/ehci_def.h from host/ehci.h
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>

so long as the minor issue below is fixed:


>  
> 	...
> +#include <linux/usb/ehci_def.h>
>  
>  /*-------------------------------------------------------------------------*/
>  
> +

Only one blank line needed please.  ;)


>  #define	QTD_NEXT(ehci, dma)	cpu_to_hc32(ehci, (u32)dma)
>  
>  /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/