linux-kernel - [patch] signalfd: fix undefined reference to `compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080725110616.GA29447@elte.hu>
Date:	Fri, 25 Jul 2008 13:06:16 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Ulrich Drepper <drepper@...hat.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	akpm@...ux-foundation.org, davidel@...ilserver.org,
	mtk.manpages@...il.com, torvalds@...ux-foundation.org
Subject: [patch] signalfd: fix undefined reference to `compat_sys_signalfd4'


* Ulrich Drepper <drepper@...hat.com> wrote:

> This patch adds the new signalfd4 syscall.  It extends the old 
> signalfd syscall by one parameter which is meant to hold a flag value.  
> In this patch the only flag support is SFD_CLOEXEC which causes the 
> close-on-exec flag for the returned file descriptor to be set.

this patch causes the following build failure on !CONFIG_SIGNALFD:

 arch/x86/ia32/built-in.o: In function `ia32_sys_call_table':
 (.rodata+0xa38): undefined reference to `compat_sys_signalfd4'
 make: *** [.tmp_vmlinux1] Error 1

tested fix below.

	Ingo

-------------->
>From 72dc5d608422e80ad5e1aac2d7b9bd16b7dbc6e0 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Fri, 25 Jul 2008 13:02:37 +0200
Subject: [PATCH] signalfd: fix undefined reference to `compat_sys_signalfd4'

fix:

arch/x86/ia32/built-in.o: In function `ia32_sys_call_table':
(.rodata+0xa38): undefined reference to `compat_sys_signalfd4'

on !CONFIG_SIGNALFD.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 kernel/sys_ni.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index 55eca15..08d6e1b 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -160,6 +160,7 @@ cond_syscall(sys_ioprio_get);
 cond_syscall(sys_signalfd);
 cond_syscall(sys_signalfd4);
 cond_syscall(compat_sys_signalfd);
+cond_syscall(compat_sys_signalfd4);
 cond_syscall(sys_timerfd_create);
 cond_syscall(sys_timerfd_settime);
 cond_syscall(sys_timerfd_gettime);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/