linux-kernel - Re: Large increase in context switch rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1216985963.7257.373.camel@twins>
Date:	Fri, 25 Jul 2008 13:39:23 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Alex Nixon <alex.nixon@...rix.com>
Cc:	Nick Piggin <nickpiggin@...oo.com.au>,
	"Alex Nixon (Intern)" <Alex.Nixon@...citrix.com>,
	Andi Kleen <andi@...stfloor.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ian Campbell <Ian.Campbell@...citrix.com>,
	Theodore Ts'o <tytso@....edu>,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: Large increase in context switch rate

On Fri, 2008-07-25 at 12:31 +0100, Alex Nixon wrote:
> >> I've bisected down to commit ba52de123d454b57369f291348266d86f4b35070 -
> >> [PATCH] inode-diet.  Before that kernbench consistently reports about
> >> 35k context switches (total), and after that commit about 53k.  The
> >> benchmarks are being run on a tmpfs.  I've verified the results on a
> >> different machine, albeit with an almost identical setup (the same
> >> kernels and debian distro, kernbench version, and benchmarking a build
> >> of the same source).
> >>
> >> Seems to be a mystery why that patch is (seemingly) the culprit...
> 
> The relevant changeset had caused the blocksize to default to 1024 (as opposed
> to 4096) - as a result there was a large increase in the time spent waiting on
> pipes.
> 
> Instead of re-adding the line taken out of fs/pipe.c by Theodore I opted instead
> to change the default block size for pseudo-filesystems to PAGE_SIZE, to try
> avoid making pipe.c inconsistent with Theodore's new approach.
> 
> The performance penalty from these extra context switches is fairly small, but 
> is magnified when virtualization is involved, hence the desire to keep it lower
> if possible.
> 
> 
> From 4b568a72fc42b52279507eb4d1339e0637ae719a Mon Sep 17 00:00:00 2001
> From: Alex Nixon <t_alexn@...xn-desktop.(none)>
> Date: Fri, 25 Jul 2008 11:26:44 +0100
> Subject: [PATCH] VFS: increase pseudo-filesystem block size to PAGE_SIZE.
> 
> Changeset ba52de123d454b57369f291348266d86f4b35070 caused the block size used
> by pseudo-filesystems to decrease from PAGE_SIZE to 1024 leading to a doubling
> of the number of context switches during a kernbench run.

Cool - makes sense. I'd ack it, but I know less than nothing about this
code, so I won't...

Still, good hunting on your part!

> Signed-off-by: Alex Nixon <Alex.Nixon@...rix.com>
> ---
>  fs/libfs.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/libfs.c b/fs/libfs.c
> index baeb71e..1add676 100644
> --- a/fs/libfs.c
> +++ b/fs/libfs.c
> @@ -216,8 +216,8 @@ int get_sb_pseudo(struct file_system_type *fs_type, char *name,
>  
>  	s->s_flags = MS_NOUSER;
>  	s->s_maxbytes = ~0ULL;
> -	s->s_blocksize = 1024;
> -	s->s_blocksize_bits = 10;
> +	s->s_blocksize = PAGE_SIZE;
> +	s->s_blocksize_bits = PAGE_SHIFT;
>  	s->s_magic = magic;
>  	s->s_op = ops ? ops : &simple_super_operations;
>  	s->s_time_gran = 1;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/