linux-kernel - Re: [PATCH 2/5] drivers/scsi/aic94xx/: replace __FUNCTION__ with __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217006041.15288.13.camel@localhost.localdomain>
Date:	Fri, 25 Jul 2008 13:14:01 -0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	rae l <crquan@...il.com>
Cc:	djwong@...ibm.com, linux-scsi@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	Harvey Harrison <harvey.harrison@...il.com>
Subject: Re: [PATCH 2/5] drivers/scsi/aic94xx/: replace __FUNCTION__ with
	__func__

On Sat, 2008-07-26 at 01:08 +0800, rae l wrote:
> On Sat, Jul 26, 2008 at 12:42 AM, Darrick J. Wong <djwong@...ibm.com> wrote:
> > On Fri, Jul 25, 2008 at 10:48:33AM +0800, Denis ChengRq wrote:
> >> Signed-off-by: Denis ChengRq <crquan@...il.com>
> >
> > No justification or changelog?
> I think no more explanation needed, the subject is definite.
> 
> and no justification happened here, (there are justifications otherwhere)
> 
> >> -             __FUNCTION__)
> >> +             __func__)
> >
> > include/linux/kernel.h:503:#define __FUNCTION__ (__func__)
> This solution is not completely,
> 
> >
> > I assume you're trying to kill this?
> Eventually we will need a replace in the whole tree:
> 
> grep -RsInw __FUNCTION__ . |xargs sed -i -e 's/__FUNCTION__/__func__/g'

Actually, we already have such a maintained patch by Harvey Harrison, so
we don't really need another.

Since nearly every other subsystem has done this, I was thinking we
could do it around -rc1 which should cause the minimal disruption.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/