linux-kernel - Re: [patch] mm/hugetlb.c: fix build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080725183549.GA23562@elte.hu>
Date:	Fri, 25 Jul 2008 20:35:49 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [patch] mm/hugetlb.c: fix build failure


* Ingo Molnar <mingo@...e.hu> wrote:

> on !CONFIG_SYSCTL on x86 with latest -git i get:
>     
>      mm/hugetlb.c: In function 'decrement_hugepage_resv_vma':
>      mm/hugetlb.c:83: error: 'reserve' undeclared (first use in this function)
>      mm/hugetlb.c:83: error: (Each undeclared identifier is reported only once
>      mm/hugetlb.c:83: error: for each function it appears in.)

the above build error came from a bisection run, the fix i sent was for 
this build error:

  mm/hugetlb.c: In function ‘hugetlb_acct_memory': mm/hugetlb.c:1507:
  error: implicit declaration of function ‘cpuset_mems_nr'

but i also get a second hugetlb build failure on 64-bit x86:

  arch/x86/mm/built-in.o: In function `setup_hugepagesz':
  hugetlbpage.c:(.init.text+0xb49): undefined reference to `hugetlb_add_hstate'

fixed by the patch below.

	Ingo

---------------->
>From 3a13a39219ac145913e51dfddc7c4d912586c15f Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Fri, 25 Jul 2008 20:45:52 +0200
Subject: [PATCH] hugetlbfs: fix build failure on 64-bit x86

fix:

 arch/x86/mm/built-in.o: In function `setup_hugepagesz':
 hugetlbpage.c:(.init.text+0xb49): undefined reference to `hugetlb_add_hstate'

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/mm/hugetlbpage.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/hugetlbpage.c b/arch/x86/mm/hugetlbpage.c
index 8f307d9..977d185 100644
--- a/arch/x86/mm/hugetlbpage.c
+++ b/arch/x86/mm/hugetlbpage.c
@@ -425,7 +425,7 @@ hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
 
 #endif /*HAVE_ARCH_HUGETLB_UNMAPPED_AREA*/
 
-#ifdef CONFIG_X86_64
+#if defined(CONFIG_X86_64) && defined(CONFIG_SYSCTL)
 static __init int setup_hugepagesz(char *opt)
 {
 	unsigned long ps = memparse(opt, &opt);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/