linux-kernel - Re: [patch 2.6.26-git] genirq: better warning on irqchip->set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200807251202.07599.david-b@pacbell.net>
Date:	Fri, 25 Jul 2008 12:02:07 -0700
From:	David Brownell <david-b@...bell.net>
To:	Uwe Kleine-König <Uwe.Kleine-Koenig@...i.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 2.6.26-git] genirq:  better warning on irqchip->set_type() failure

From: David Brownell <dbrownell@...rs.sourceforge.net>

While I'm glad to finally see the hole fixed whereby passing an
invalid IRQ trigger type to request_irq() would be ignored, the
current diagnostic isn't quite useful.  Fixed by also listing
the trigger type which was rejected.

Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
Acked-by: Uwe Kleine-König <Uwe.Kleine-Koenig@...i.com>
---
Minor change:  cast trigger mode to int, one compiler warned.

 kernel/irq/manage.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/kernel/irq/manage.c	2008-07-25 02:07:05.000000000 -0700
+++ b/kernel/irq/manage.c	2008-07-25 02:08:13.000000000 -0700
@@ -326,7 +326,8 @@ static int __irq_set_trigger(struct irq_
 	ret = chip->set_type(irq, flags & IRQF_TRIGGER_MASK);
 
 	if (ret)
-		pr_err("setting flow type for irq %u failed (%pF)\n",
+		pr_err("setting trigger mode %d for irq %u failed (%pF)\n",
+				(int)(flags & IRQF_TRIGGER_MASK),
 				irq, chip->set_type);
 
 	return ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/