linux-kernel - isdn/eicon: msg_in_{wrap,read}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <488A28F3.6030100@gmail.com>
Date:	Fri, 25 Jul 2008 15:26:43 -0400
From:	roel kluin <roel.kluin@...il.com>
To:	mac@...ware.de
CC:	linux-kernel@...r.kernel.org
Subject: isdn/eicon: msg_in_{wrap,read}_pos assigned twice?

vi drivers/isdn/hardware/eicon/message.c +4035

and note two similar tests on line 4035 and 4049:

[else] if (plci->msg_in_read_pos == plci->msg_in_wrap_pos)

after the first test:

	plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;
	plci->msg_in_read_pos = i + MSG_IN_OVERHEAD;

but then after the second test as well:

	plci->msg_in_read_pos = MSG_IN_QUEUE_SIZE;
	plci->msg_in_wrap_pos = MSG_IN_QUEUE_SIZE;

So the assignment after the first test has no effect. Is this a bug?

Roel Kluin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/