linux-kernel - Re: [2.6 patch] linux/swap.h must #include <linux/pagemap.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Jul 2008 20:30:34 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hugh@...itas.com>, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] linux/swap.h must #include <linux/pagemap.h>

On Sat, 26 Jul 2008 20:38:32 +0300
Adrian Bunk <bunk@...nel.org> wrote:

> The patch is not the correct fix since the actual problem comes from 
> free_pages_and_swap_cache() in swap.h

True, but I saw this comment in swap.h:

/* only sparc can not include linux/pagemap.h in this file
 * so leave page_cache_release and release_pages undeclared... */

so I thought it might be safer to add the include to tlb.h instead.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/