linux-kernel - Re: [PATCH 06/24] x86/oprofile: Renaming athlon_*() into op_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080726095540.GC25890@elte.hu>
Date:	Sat, 26 Jul 2008 11:55:40 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Robert Richter <robert.richter@....com>
Cc:	Barry Kasindorf <barry.kasindorf@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	oprofile-list <oprofile-list@...ts.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/24] x86/oprofile: Renaming athlon_*() into op_amd_*()


* Robert Richter <robert.richter@....com> wrote:

> -struct op_x86_model_spec const op_athlon_spec = {
> +struct op_x86_model_spec const op_amd_spec = {
>  	.init = op_amd_init,
>  	.exit = op_amd_exit,
>  	.num_counters = NUM_COUNTERS,
>  	.num_controls = NUM_CONTROLS,
> -	.fill_in_addresses = &athlon_fill_in_addresses,
> -	.setup_ctrs = &athlon_setup_ctrs,
> -	.check_ctrs = &athlon_check_ctrs,
> -	.start = &athlon_start,
> -	.stop = &athlon_stop,
> -	.shutdown = &athlon_shutdown
> +	.fill_in_addresses = &op_amd_fill_in_addresses,
> +	.setup_ctrs = &op_amd_setup_ctrs,
> +	.check_ctrs = &op_amd_check_ctrs,
> +	.start = &op_amd_start,
> +	.stop = &op_amd_stop,
> +	.shutdown = &op_amd_shutdown
>  };

minor style comment: while we are at touching these initializers, could 
you also do a followup cleanup patch that uses the standard initializer 
style of arch/x86 that have the initializer values aligned vertically? 

Sample:

static const struct file_operations ptdump_fops = {
	.open		= ptdump_open,
	.read		= seq_read,
	.llseek		= seq_lseek,
	.release	= single_release,
};

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/