linux-kernel - Re: [PATCH 22/24] x86/oprofile: Add CONFIG_OPROFILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080726101520.GJ25890@elte.hu>
Date:	Sat, 26 Jul 2008 12:15:20 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Robert Richter <robert.richter@....com>
Cc:	Barry Kasindorf <barry.kasindorf@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	oprofile-list <oprofile-list@...ts.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 22/24] x86/oprofile: Add CONFIG_OPROFILE_IBS option


* Robert Richter <robert.richter@....com> wrote:

> +config OPROFILE_IBS
> +	bool "OProfile AMD IBS support (EXPERIMENTAL)"
> +	default n
> +	depends on OPROFILE && SMP && X86
> +	help
> +          Instruction-Based Sampling (IBS) is a new profiling
> +          technique that provides rich, precise program performance
> +          information. IBS is introduced by AMD Family10h processors
> +          (AMD Opteron Quad-Core processor ???Barcelona???) to overcome
> +          the limitations of conventional performance counter
> +          sampling.

weird UTF characters in the description - please try to use ASCII in 
such general Kconfig help-texts.

also, it would be nice to have a pure technical description. I.e. 
something like:

> +          Instruction-Based Sampling (IBS) is a new hardware feature
> +          that provides precise, non-statistical profiling 
> +          information. IBS is available in AMD Family10h processors.
> +          (AMD Barcelona).

> +#ifdef CONFIG_OPROFILE_IBS
>  	op_amd_handle_ibs(regs, msrs);
> +#endif

please hide #ifdefs by making the op_amd_handle_ibs() function general.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/