linux-kernel - Re: [PATCH 4/4] remove <linux/hdreg.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200807271728.05518.bzolnier@gmail.com>
Date:	Sun, 27 Jul 2008 17:28:05 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] remove <linux/hdreg.h>

On Thursday 24 July 2008, Christoph Hellwig wrote:
> On Thu, Jul 24, 2008 at 10:11:52PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Thursday 24 July 2008, Christoph Hellwig wrote:
> > > On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > It has no in-kernel users now and can be removed.
> > > 
> > > But beeing an exported header it has userspace users.  Plese keep it
> > > and just leave the ioctl defintions as need by userspace in it instead
> > > of renaming that part to hdio_ioctls.h.
> > 
> > Agreed w.r.t. to keeping it (the last patch was more of rfc than intended
> > to be commited, sorry that I didn't mark it as such) but what's wrong with
> > moving ioctl definitions to hdio_ioctls.h so we have clean separation of
> > obsoleted userspace-only stuff & userspace/kernel stuff?
> 
> Well, if there was anything kernel-related left in hdreg.h I would
> agree to split it, although I'd prefer to move the kernel part out.
> 
> But given that you kill all the kernel only bits anyway, just leave
> the user interface in hdreg.h even if it's slightly misnamed.

Yep, no need to move it around.  I reworked patchset accordingly.

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/