linux-kernel - Re: [PATCH] usb: don't hide bios bug warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080727012454.GA22219@suse.de>
Date:	Sat, 26 Jul 2008 18:24:54 -0700
From:	Greg KH <gregkh@...e.de>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: don't hide bios bug warning

On Sat, Jul 26, 2008 at 06:12:15PM -0700, Yinghai Lu wrote:
> 
> quirk_usb_disable_handoff will wait a while if there is BIOS bug.
> let the end user know the reason for that.
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
> 
> ---
>  drivers/usb/host/pci-quirks.c |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6/drivers/usb/host/pci-quirks.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/host/pci-quirks.c
> +++ linux-2.6/drivers/usb/host/pci-quirks.c
> @@ -190,7 +190,8 @@ static void __devinit quirk_usb_handoff_
>  			msleep(10);
>  		}
>  		if (wait_time <= 0)
> -			dev_warn(&pdev->dev, "OHCI: BIOS handoff failed"
> +			dev_printk(KERN_WARNING, &pdev->dev,
> +					"OHCI: BIOS handoff failed"

This is the exact same thing here, no change.

> @@ -242,7 +243,8 @@ static void __devinit quirk_usb_disable_
>  		switch (cap & 0xff) {
>  		case 1:			/* BIOS/SMM/... handoff support */
>  			if ((cap & EHCI_USBLEGSUP_BIOS)) {
> -				dev_dbg(&pdev->dev, "EHCI: BIOS handoff\n");
> +				dev_printk(KERN_DEBUG, &pdev->dev,
> +						"EHCI: BIOS handoff\n");

Is this what you really want to see?  But you just made things noiser.

> @@ -283,7 +285,8 @@ static void __devinit quirk_usb_disable_
>  				/* well, possibly buggy BIOS... try to shut
>  				 * it down, and hope nothing goes too wrong
>  				 */
> -				dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
> +				dev_printk(KERN_WARNING, &pdev->dev,
> +						"EHCI: BIOS handoff failed"

This is the exact same thing, no change.

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/