linux-kernel - 2.6.26-mmotm-0724 - linux-next.git loses /proc/sys/fs/quota, breaks disk quotas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <14615.1217125366@turing-police.cc.vt.edu>
Date:	Sat, 26 Jul 2008 22:22:46 -0400
From:	Valdis.Kletnieks@...edu
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: 2.6.26-mmotm-0724 - linux-next.git loses /proc/sys/fs/quota, breaks disk quotas

I bisected the problem to somewhere in here:

repeatable-slab-corruption-with-ltp-msgctl08.patch GOOD
#
linux-next.patch
linux-next-git-rejects.patch
linux-next-fixup.patch BAD

I have no idea how to go bisecting through linux-next.patch

It works in 26-mmotm-0715, but is broken in -0724, so that will hopefully
narrow the suspect commits down a *little* bit...

The problem is that the userspace does this:

        /* Detect new kernel interface; Assume generic interface unless we can p
rove there is not one... */
        if (!stat("/proc/sys/fs/quota", &st) || errno != ENOENT) {
                kernel_iface = IFACE_GENERIC;
                kernel_formats |= (1 << QF_VFSOLD) | (1 << QF_VFSV0);
        }
        else {
                struct v2_dqstats v2_stats;

and /proc/sys/fs/quota has mysteriously vanished in -0724. As a result,
the userspace code goes looking for the quotav1 files and doesn't find them,
since the actual files on disk are quotav2 (with a different name).

fs/dquot.c, which contains the code for that, appears to be identical in -0715
and -0724, so something *else* is breaking it.

Anybody know where /proc/sys/fs/quota went?

Content of type "application/pgp-signature" skipped