[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <86802c440807262024x56ea8defpabcc70f66b27baf9@mail.gmail.com>
Date: Sat, 26 Jul 2008 20:24:53 -0700
From: "Yinghai Lu" <yhlu.kernel@...il.com>
To: "David Brownell" <david-b@...bell.net>
Cc: gregkh@...e.de, mingo@...e.hu, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] usb: don't hide bios bug warning
On Sat, Jul 26, 2008 at 6:56 PM, David Brownell <david-b@...bell.net> wrote:
>> >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
>> >> + dev_printk(KERN_WARNING, &pdev->dev,
>> >> + "EHCI: BIOS handoff failed"
>> >
>> > This is the exact same thing, no change.
>> >
>> > confused,
>>
>> end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
>
> Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
> which is toggled (via DEBUG) by CONFIG_USB_DEBUG...
you are right,
please forget about the patch.
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists