linux-kernel - Re: [PATCH 1/2] leds: make the default trigger name const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080727020857.GM12191@secretlab.ca>
Date:	Sat, 26 Jul 2008 20:08:57 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Trent Piepho <tpiepho@...escale.com>
Cc:	linux-kernel@...r.kernel.org,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Kumar Gala <galak@...nel.crashing.org>, linuxppc-dev@...abs.org
Subject: Re: [PATCH 1/2] leds: make the default trigger name const

On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote:
> The default_trigger fields of struct gpio_led and thus struct led_classdev
> are pretty much always assigned from a string literal, which means the
> string can't be modified.  Which is fine, since there is no reason to
> modify the string and in fact it never is.
> 
> But they should be marked const to prevent such code from being added, to
> prevent warnings if -Wwrite-strings is used and when assigned from a
> constant string other than a string literal (which produces a warning under
> current kernel compiler flags), and for general good coding practices.
> 
> Signed-off-by: Trent Piepho <tpiepho@...escale.com>
Acked-by: Grant Likely <grant.likely@...retlab.ca>
> ---
>  include/linux/leds.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 519df72..defe693 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -48,7 +48,7 @@ struct led_classdev {
>  
>  	struct device		*dev;
>  	struct list_head	 node;			/* LED Device list */
> -	char			*default_trigger;	/* Trigger to use */
> +	const char		*default_trigger;	/* Trigger to use */
>  
>  #ifdef CONFIG_LEDS_TRIGGERS
>  	/* Protects the trigger data below */
> @@ -121,7 +121,7 @@ extern void ledtrig_ide_activity(void);
>  /* For the leds-gpio driver */
>  struct gpio_led {
>  	const char *name;
> -	char *default_trigger;
> +	const char *default_trigger;
>  	unsigned 	gpio;
>  	u8 		active_low;
>  };
> -- 
> 1.5.4.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/