linux-kernel - Re: [git pull] cpus4096 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Jul 2008 10:53:57 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mike Travis <travis@....com>
Subject: Re: [git pull] cpus4096 fixes

On Monday 28 July 2008 05:06:01 Ingo Molnar wrote:
> Linus,
>
> Please pull the latest cpus4096-fixes git tree from:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git
> cpus4096
>
> this fixes the cpumask_of_cpu API fallout described here:
>
>    http://lkml.org/lkml/2008/7/23/76
>
> ... and the fix is wider than i'd like it to be, so close to -rc1

Sorry, it's wider because you pushed the last stupid Mike patch.  Over my 
(obviously too-polite) objections.  Most of this is reverting that, just 
without actually admitting it.

> - but 
> it's the cleanest one and it has Rusty's ack as well.

Not really.  As authored, I intended it as a bandaid for systems with small 
CPU numbers.  Mike made it always on (tho __initdata on large x86 systems), 
which IMHO is insane (2MB of initdata?).

Mike: I now think the right long-term answer is Linus' dense cpumap idea + a 
convenience allocator for cpumasks.  We sweep the kernel for all on-stack 
vars and replace them with one or the other.  Thoughts?

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/