linux-kernel - Re: [PATCH] Remove stray <6> in BogoMIPS printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080728122401.GB5515@elte.hu>
Date:	Mon, 28 Jul 2008 14:24:01 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Joe Perches <joe@...ches.com>
Cc:	Rabin Vincent <rabin@....in>, lkml <linux-kernel@...r.kernel.org>,
	akataria@...are.com, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Remove stray <6> in BogoMIPS printk


* Joe Perches <joe@...ches.com> wrote:

> On Sun, 2008-07-27 at 23:47 +0530, Rabin Vincent wrote:
> > Remove the extra KERN_INFO which causes this:
> > Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
> > -	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> > -			loops_per_jiffy/(500000/HZ),
> > -			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> > +	printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
> > +		loops_per_jiffy/(500000/HZ),
> > +		(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> >  }
> 
> How about just using KERN_CONT and leaving the whitespace
> for a patch that does the entire file?
> 
> diff --git a/init/calibrate.c b/init/calibrate.c
> index 7963e3f..51c5cec 100644
> --- a/init/calibrate.c
> +++ b/init/calibrate.c
> @@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
>  				loops_per_jiffy &= ~loopbit;
>  		}
>  	}
> -	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> +	printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
>  			loops_per_jiffy/(500000/HZ),
>  			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);

ok - i've applied the patch below. Please send the full-file cleanup as 
a separate patch if anyone is interested in doing it.

	Ingo

------------>
>From d7ba11d01cfedf63b50391fbe4a05274b6992b43 Mon Sep 17 00:00:00 2001
From: Joe Perches <joe@...ches.com>
Date: Sun, 27 Jul 2008 12:02:04 -0700
Subject: [PATCH] x86: remove stray <6> in BogoMIPS printk

Rabin Vincent noticed that there's a stray <6> in BogoMIPS printk:

> Remove the extra KERN_INFO which causes this:
> Calibrating delay loop... <6>179.40 BogoMIPS (lpj=897024)
> -	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
> -			loops_per_jiffy/(500000/HZ),
> -			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
> +	printk("%lu.%02lu BogoMIPS (lpj=%lu)\n",
> +		loops_per_jiffy/(500000/HZ),
> +		(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
>  }

How about just using KERN_CONT and leaving the whitespace
for a patch that does the entire file?

Reported-by: Rabin Vincent <rabin@....in>
---
 init/calibrate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/init/calibrate.c b/init/calibrate.c
index 7963e3f..a379c90 100644
--- a/init/calibrate.c
+++ b/init/calibrate.c
@@ -170,7 +170,7 @@ void __cpuinit calibrate_delay(void)
 				loops_per_jiffy &= ~loopbit;
 		}
 	}
-	printk(KERN_INFO "%lu.%02lu BogoMIPS (lpj=%lu)\n",
+	printk(KERN_CONT "%lu.%02lu BogoMIPS (lpj=%lu)\n",
 			loops_per_jiffy/(500000/HZ),
 			(loops_per_jiffy/(5000/HZ)) % 100, loops_per_jiffy);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/